-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
"jquery.foo.js"
Current homepage points to an expired domain http://getsprockets.org This PR updates it to point at the github repo instead.
Update homepage
preventing "undefined method `directory?' for nil:NilClass" when a link to a non-existent file is present
Correct minor spelling mistakes in README.md
Guard against nil stat
This reverts commit ef6d89b. Conflicts: lib/sprockets/server.rb
…nderlove-set Conflicts: lib/sprockets/processed_asset.rb
Conflicts: lib/sprockets/bundled_asset.rb lib/sprockets/context.rb lib/sprockets/server.rb sprockets.gemspec
No new calls need to be added there. We can already pass options to |
The one think that is blocking me from progress here is the pipeline processor api. I'm working on redoing it for 3.0 first. Once thats out that will allow processors to pass extra data between each other like source maps. |
The reason for Or we could do it like coffee-rails-source-maps and just write to a temporary file. |
It doesn't really matter, we can invoke whatever api the processor exposes here. https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/coffee_script_template.rb#L9 There isn't even a unified api right now, so I'm expecting everyone to expose different source map apis. Coffee, Uglifier, Sass, YUI, ClosureCompiler are all going to do different things. Our wrappers will normalize them. I worked on https://github.com/maccman/sourcemap which is a useful Ruby structure around the json object. Thats what I plan to hand off between processors.
Nothing should be written to disk when templates are compiled. It should be a "pure functional" transformation. |
On Fri, Feb 14, 2014 at 11:30 AM, Joshua Peek [email protected]:
I worked on https://github.com/maccman/sourcemap which is a useful Ruby
|
You can just pass whatever options to https://github.com/josh/ruby-coffee-script/blob/master/lib/coffee_script.rb#L47 Though, I'm thinking having a separate |
Do you need any help with source map support? This task is really important to me. |
This is taking forever...#311 started 2 years ago...ugh. Really want to see this finally land. |
Grunt already has source map support. Even Mincer (Sprockets port to node.js). So I think this feature is very important, because source map helps with Sass and CoffeeScript debug. |
I too offer to help on source maps if you need it. |
+1 - happy to review / test / etc. |
Merge master into the source map branch (fixes some syntax changes). We could rebase if you guys are au fait with that.
To make this actually useful there are about three parallelizable tasks:
compile_with_map
compile_with_map
to the coffee script gem.I'm planning to spend a small amount of time working on this, but don't expect anything quickly.